Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ameerul /remove p2p from cashier #7777

Merged
merged 19 commits into from
Apr 12, 2023
Merged

Ameerul /remove p2p from cashier #7777

merged 19 commits into from
Apr 12, 2023

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Mar 1, 2023
@vercel
Copy link

vercel bot commented Mar 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 5:56am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/7777](https://github.com/binary-com/deriv-app/pull/7777)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx?qa_server=red.binaryws.com&app_id=32882
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx
- **App ID**: `32882`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx/

@ameerul-deriv
chore: cherry picked
9a3da34 
Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com>
@boring-cyborg boring-cyborg bot added the Core label Mar 9, 2023
@ameerul-deriv ameerul-deriv changed the base branch from develop to master March 9, 2023 08:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023 •
edited
Loading

Codecov Report

Merging #7777 (cd3b7ec) into master (ba1aef5) will decrease coverage by 0.13%.
The diff coverage is 3.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #7777      +/-   ##
==========================================
- Coverage   20.86%   20.74%   -0.13%     
==========================================
  Files        1539     1538       -1     
  Lines       35942    35940       -2     
  Branches     7031     7030       -1     
==========================================
- Hits         7500     7454      -46     
- Misses      27688    27739      +51     
+ Partials      754      747       -7
Impacted Files Coverage Δ
packages/cashier/src/constants/routes-config.ts 88.23% <ø> (ø)
packages/core/src/Stores/notification-store.js 0.00% <0.00%> (ø)
...onents/advertiser-page/advertiser-page-adverts.jsx 10.00% <0.00%> (-1.12%) ⬇️
...components/advertiser-page/advertiser-page-row.jsx 12.50% <0.00%> (ø)
...mponents/advertiser-page/advertiser-page-stats.jsx 4.34% <0.00%> (-0.20%) ⬇️
packages/p2p/src/components/app.jsx 0.00% <0.00%> (ø)
...kages/p2p/src/components/buy-sell/buy-sell-row.jsx 0.00% <0.00%> (ø)
...ges/p2p/src/components/buy-sell/buy-sell-table.jsx 0.00% <0.00%> (ø)
...components/daily-limit-modal/daily-limit-modal.jsx 0.00% <0.00%> (ø)
...l-manager/modals/buy-sell-modal/buy-sell-modal.jsx 0.00% <ø> (ø)
... and 25 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

farzin-deriv
farzin-deriv reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@farzin-deriv farzin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work pal 🚀

packages/p2p/src/components/advertiser-page/advertiser-page-adverts.jsx Show resolved Hide resolved
packages/p2p/@deriv-stores.d.ts Outdated Show resolved Hide resolved
packages/p2p/src/components/modal-manager/modals/rate-change-modal/rate-change-modal.jsx Show resolved Hide resolved
packages/p2p/src/declarations.d.ts Outdated Show resolved Hide resolved
farzin-deriv
farzin-deriv previously approved these changes Mar 24, 2023
View reviewed changes
adrienne-deriv
adrienne-deriv previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niloofar-deriv
niloofar-deriv previously approved these changes Mar 26, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@hamid-deriv hamid-deriv merged commit f12eb13 into deriv-com:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienne-deriv adrienne-deriv adrienne-deriv left review comments

@niloofar-deriv niloofar-deriv niloofar-deriv left review comments

@farzin-deriv farzin-deriv farzin-deriv left review comments

Assignees
No one assigned
Labels
Components Core P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ameerul-deriv @codecov-commenter @farzin-deriv @niloofar-deriv @adrienne-deriv @hamid-deriv